Addition of Special Abilities#8
Merged
ScottWilson0903 merged 9 commits intoNov 18, 2021
Merged
Conversation
Added rulebook patching for special abilities Added SpecialAbilityIdentifier.cs Refactored StatIconInfo.cs to now point at LoadAbilityData
Refactored to now check if the ability already exists. Added Card_AttachAbilities_NewSpecialAbilities.cs to add SpecialAbilities. Cleaned up AbilitiesUtil.cs and AbilityIdentifier.cs
Refactored CustomCard to include special abilities now
ScottWilson0903
requested changes
Nov 18, 2021
| public SpecialAbilityIdentifier id; | ||
|
|
||
| public NewSpecialAbility( | ||
| StatIconInfo statIconInfo, |
Collaborator
There was a problem hiding this comment.
statIconInfo is optional, so should be nullable here
| NewSpecialAbility newAbility = NewSpecialAbility.specialAbilities | ||
| .Find(x => x.specialTriggeredAbility == specialTriggeredAbility); | ||
| Type type = newAbility.abilityBehaviour; | ||
| Plugin.Log.LogInfo($"-> Type is [{type}]"); |
Collaborator
There was a problem hiding this comment.
This probably wants more information or wants to be a debug message
| min, | ||
| doAddPageFunc, | ||
| __instance.FillStatIconPage, | ||
| Localization.Translate("APPENDIX XII, SUBSECTION I - MOD SPEC. ABILITIES {0}"))); |
Collaborator
There was a problem hiding this comment.
APPENDIX XII, SUBSECTION II - VARIABLE STATS {0}
| { | ||
| NewCard.cards[item.Key].abilities.Add(id.id); | ||
| // if the card already has the ability then no point and adding it | ||
| if (!newCard.abilities.Contains(id.id)) newCard.abilities.Add(id.id); |
Collaborator
There was a problem hiding this comment.
Some abilities can stack. If you try to add a duplicate which can't stack, then it will be removed, but certain abilitiies stack
Collaborator
There was a problem hiding this comment.
A fix for toRemove does need to be added to make this work as intended but I have the code for that and will add it after I merge
| { | ||
| CustomCard.cards[item.Key].abilities.Add(id.id); | ||
| // if the card already has the ability then no point and adding it | ||
| if (!customCard.abilities.Contains(id.id)) customCard.abilities.Add(id.id); |
Added method for handling StatIconInfo
Contributor
Author
|
For an example of a working example: https://github.com/julian-perge/InscryptionMods/blob/main/Cards_And_Abilities/MoreAnts/DomeAnt.cs
|
ScottWilson0903
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.